-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Robustify speech recognition test #76652
Conversation
Tagging subscribers to this area: @danmoseley Issue DetailsFix #76626 (?) I can't reproduce the failure despite looping the tests for some time while keeping the machine busy doing builds. So I really have no theory why it failed.
Also added an error case test with silence. (Was not able to find an input string that it would refuse to recognize. It always just had low confidence.)
|
Looks like I should use "Contains"
Also retries, as this should be ~0.85 confidence, somethings' all wrong in this case. |
The combination of this should do it. |
test failures are unrelated: #76681 |
Fixed typo, since rerunning might not be a bad thing. |
@carlossanlop maybe you could review? I expect checks to be green/known failures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just left a non-blocking question.
CI failures are unrelated:
Fix #76626 (?)
I can't reproduce the failure despite looping the tests for some time while keeping the machine busy doing builds. So I really have no theory why it failed.
Also added an error case test with silence. (Was not able to find an input string that it would refuse to recognize. It always just had low confidence. White noise does lead to failure, but I don't have a quick way to make that in a test.)